NOISSUE - Use github action for showing OpenAPI spec with Swagger UI #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1427 +/- ##
==========================================
- Coverage 69.26% 69.24% -0.03%
==========================================
Files 123 123
Lines 8454 8454
==========================================
- Hits 5856 5854 -2
- Misses 2072 2074 +2
Partials 526 526
Continue to review full report at Codecov.
|
dborovcanin
previously approved these changes
Jun 23, 2021
dborovcanin
reviewed
Jun 23, 2021
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
blokovi
dismissed stale reviews from dborovcanin, drasko, darkodraskovic, and manuio
via
59dd554
Signed-off-by: Ivan Milosevic <iva@blokovi.com>
Thanks @dusanb94 , done. |
manuio
suggested changes
Jun 23, 2021
| @@ -103,6 +103,6 @@ If `MF_EMAIL_TEMPLATE` doesn't point to any file service will function but passw | |||
| ## Usage | |||
|
|
|||
| For more information about service capabilities and its usage, please check out | |||
| the [API documentation](openapi.yml). | |||
| the [API documentation](https://api.mainflux.io/?urls.primaryName=auth-openapi.yml). | |||
There was a problem hiding this comment.
Why this url? It should be api/auth-openapi.yml, right?
There was a problem hiding this comment.
Yes @manuio , raw yml file is there. But on api.mainflux.io domain, it will be shown in SwaggerUI which is more user friendly
dborovcanin
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ivan Milosevic iva@blokovi.com
What does this do?
api.mainflux.io)/apifolderWhich issue(s) does this PR fix/relate to?
No issue